Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=713443 Matthias Clasen <mcla...@redhat.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mcla...@redhat.com --- Comment #1 from Matthias Clasen <mcla...@redhat.com> 2011-06-15 23:20:29 EDT --- Quick initial comments, more thorough review to follow a bit later: - builds fine in mock, thats great - it produces an empty debuginfo package, because there are no binaries in the main package that debuginfo could be stripped out. It looks to me that you probably want to make your package noarch, since it contains just things in /usr/share and scripts, which should not be arch-dependent. Making this a noarch package will turn off debuginfo as a side-effect. You do that by adding BuildArch: noarch somewhere in the header - You have a rm -rf $RPM_BUILD_ROOT in %install. That is no longer necessary. - Typo in changelog: Initialia -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
