Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=611068

Rahul Sundaram <methe...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|r.landm...@redhat.com       |methe...@gmail.com
               Flag|fedora-review?              |fedora-review+

--- Comment #4 from Rahul Sundaram <methe...@gmail.com> 2011-06-28 23:15:37 EDT 
---

I am taking over the review since reminders to Ruediger Landmann here as well
as offlist haven't been answered.  

The following is redundant unless you are building for EPEL as well

%if ! (0%{?fedora} > 12 || 0%{?rhel} > 5)
%{!?python_sitelib: %global python_sitelib %(%{__python} -c "from
distutils.sysconfig import get_python_lib; print get_python_lib()")}
%endif

BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

%clean
rm -rf %{buildroot}

%defattr(-,root,root,-)

I would consider removing these.  Not a blocker however

                   ==== APPROVED ====

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to