Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=717502

Volker Fröhlich <volke...@gmx.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |volke...@gmx.at

--- Comment #1 from Volker Fröhlich <volke...@gmx.at> 2011-06-29 01:58:04 EDT 
---
Don't ship .la files. .so belong in a devel sub-package.

License is GPLv3+.

-n %{name}-%{version} is unnecessary.

Docs should be installed with the %doc macro in the files section.

Some BuildRequires are not needed, e.g. make (see packaging guidelines). I
guess the version requirements are unneeded too.

The version in the changelog entries are wrong.

Please check if all your files in %doc are useful. INSTALL is not.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to