Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=680174 Rex Dieter <rdie...@math.unl.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #4 from Rex Dieter <rdie...@math.unl.edu> 2011-07-19 10:08:31 EDT --- $ rpmlint *.src.rpm x86_64/*.rpm herqq.x86_64: W: file-not-utf8 /usr/share/doc/herqq-0.9.1/ChangeLog herqq.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/herqq-0.9.1/LICENSE_LGPLv3.txt herqq-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/herqq-devel-0.9.1/LICENSE_LGPLv3.txt 4 packages and 0 specfiles checked; 0 errors, 3 warnings. mostly harmless naming: ok sources: ok cb0d080da22b649a5916796bbf4d2c28 herqq-0.9.1.zip scriptlets: ok license: ok , but seems all the source code does seem to include the "or (at your option) any later version." option (unless I missed something). macros: OK, but.. SHOULD: for consistency, I'd recommend using %{_qt4_headerdir} in favor of %{_includedir} SHOULD: track shlib soname in %files, so not caught by surprise on abi changes using something like this: %{_qt4_libdir}/libHUpnp.so.0* APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
