Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=721112 --- Comment #6 from Richard Shaw <hobbes1...@gmail.com> 2011-07-20 11:43:55 EDT --- (In reply to comment #5) > (In reply to comment #4) > > I've made some progress trying to get it to build against the OpenNL package > > but I can't really test it because of: > > > > rpmbuild -bc rpmbuild/vmtk/SPECS/vmtk.spec > > error: Failed build dependencies: > > InsightToolkit-devel is needed by vmtk-0.9.0-2.fc14.x86_64 > > vxl-devel is needed by vmtk-0.9.0-2.fc14.x86_64 > > > > Because of that I've added the review request of vxl and InsightToolkit as a > > blocker for this Review Request. > > I'm sorry, I forgot to mention that you need to build ITK and vxl for your > fedora system before you can test it. I for example, have a local mock repo > with these packages. Yup, I run a local repo as well. I'll try that. > > The only part of the project that appears to use OpenNL is the > > DifferentialGeometry sub-project. > > > > I've added a cmake option, USE_EXTERN_OPENNL to the main CMakeLists.txt and > > I'm > > working on getting the headers and linking working in the CMakeLists.txt for > > DifferentialGeometry. > > > The package works with the fedora OpenNL which I packaged recently. You don't > need to make any tweaks. The changes I've made in the prep and build sections > are enough. Well, I was trying for a few reasons. One, I'm trying to improve my cmake-fu :) Also, hacking the link.txt is not ideal. If I can come up with a good cmake patch then maybe upstream will accept it (which is the best case). Also, in retrospect, I'm wondering if we should have renamed the header file for OpenNL to be consistent with the library name, i.e.: nl.h -> opennl.h What do you think? Richard -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
