Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=725292

--- Comment #2 from Jorge A Gallegos <k...@blegh.net> 2011-07-24 23:15:06 EDT 
---
Thanks for the feedback!

1. Chose %{buildroot}
2. Done
3. License is explicitly set as "GNU GPL v2" in the project page, I used
"GPLv2" (sans the +) in the spec file, is that correct?
4. Added missing libs according to
http://code.google.com/p/s3fs/wiki/InstallationNotes
5. http://code.google.com/p/s3fs/wiki/FuseOverAmazon has an important note in
the Overview section: "Important Note: Your kernel must support FUSE, kernels
earlier than 2.6.18-164 may not have FUSE support". However I think there's no
fedora release (that is not EOL'd) with a kernel that old, so perhaps you are
correct, dropped the Requires section
6. That file is supposed to be only readable by root, such as root is the only
one able to mount given the system-wide passwd file. Users can create
~/.passwd-s3fs files for user-specific mounts. Perhaps I should add a
README.Fedora file to the docs?

Updated .spec and .src.rpm files in http://kad.fedorapeople.org/packages/s3fs/

Cheers

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to