Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=705363 --- Comment #3 from Miroslav Suchý <msu...@redhat.com> 2011-07-29 07:26:12 EDT --- >TODO: I think `Spacewalk web site' or `Spacewalk web interface' would be >enough. The word (Spacewalk) `packages' interfere with RPM packages. fixed >TODO: spacewalk-html subpackage contains MIT licensed code fixed > TODO: spacewalk-base-minimal summary is too cryptic. Replace ".pm's" with > `Perl modules' or make it more human-friendly in other way. fixed > TODO: spacewalk-web package summary contains lower-case `rpm' abbreviation. > Use upper case. fixed > TODO: Some package descriptions do not end with full stop. fixed > TODO: Remove BuildRoot definition and it's cleaning as it's default behavior > of rpmbuild. Negative sir. We still care about EPEL4, where we need it. >FIX: Add Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) too all subpackages with Perl modules fixed > TODO: Add %{?_smp_mflags} to make arguments to utilize all CPU's while `compiling'. fixed > TODO: Remove %defattr macro from %files sections as this is implicit. fixed >FIX: Escape percentage symbol in changelog, otherwise it's subject of SPEC-macro expansion. fixed > Notice: Is /var/www/html/network/software/channels/keys/BETA-RPM-GPG-KEY a GPG key stored along web pages? Should it be a %config file? I don't like it. Dead files. Removed. > Also your Perl modules contain tests and other Perl infrastructure that is > not utilized by your spec file. That is because that those tests are not maintained for ages and very probably do not work. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
