Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=702987 Martin Gieseking <martin.giesek...@uos.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.giesek...@uos.de --- Comment #4 from Martin Gieseking <martin.giesek...@uos.de> 2011-07-30 14:43:08 EDT --- Some quick comments: - Would you like to update the package to the latests release? - As you're one of the upstream developers, please add the LGPL copyright header to all source files as requested by the (L)GPL (see COPYING). - The package currently doesn't build in mock because of missing BR readline-devel - There's no need to remove INSTALL in %prep. - Also, it's not necessary to wrap the BuildRoot and BuildArch fields with conditionals. Just use plain BuildRoot/BuildArch fields, even if an explicit BuildRoot tag is optional in Fedora and EPEL > 5. - After the update of the packaging guidelines, the devel package must now require the base package this way: Requires: %{name}%{?_isa} = %{version}-%{release} - The following dirs are unowned: /usr/share/stdair/samples /usr/share/stdair/samples/rds01 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
