Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=728178 --- Comment #3 from Martin Gieseking <martin.giesek...@uos.de> 2011-08-06 10:23:16 EDT --- Mario, thank you for the review! (In reply to comment #2) > I'm unsure if desktop-file-install is needed here. Anyway, we have a > *.desktop file, but other plugins for Xfce don't even have the > desktop-file-install scriptlet. No idea what to do here. Unfortunately, desktop-file-validate and desktop-file-install don't like Xfce desktop files, i.e. they report errors although the file variants conform the .desktop file specification. Thus, rpmbuild would fail spuriously if desktop-file-FOO were called. Additionally, xfce4-wmdock-plugin isn't a GUI application. Therefore it doesn't provide a "valid" .desktop file in %{_datadir}/applications/ and doesn't create a menu entry. I think the Xfce desktop files must be handled differently compared to those of GUI apps. After having a quick look at several specs of other Xfce plugins, this seems to be the common practice. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
