Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=731898

--- Comment #30 from Steve Jenkins <st...@stevejenkins.com> 2011-08-23 23:18:27 
EDT ---
(In reply to comment #29)
> A quick review of the SHOULDs during review indicates all is well also.

That's what I was goin' for. :)

> Package looks great now.  Thanks.  (often times it's easiest to start a 
> package
> from scratch rather than fix up whatever upstream happened to have done.

True - but doing it this way also taught me a whole lot, which was one of the
reasons I wanted to do this.

>  Now that you've done all this cleanup, hopefully you can submit the spec
> and patches back upstream too.)

Totally the plan, and luckily we have a very receptive upstream developer.

> APPROVED.

Alright! Thanks, Matt! I'm gonna fire up the docs so I can start learning about
what to do on the next step. :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to