Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=731456 --- Comment #5 from Pavel Alexeev (aka Pahan-Hubbitus) <pa...@hubbitus.info> 2011-09-03 11:58:56 EDT --- Legend: + - Ok. - - Error. +/- - It item acceptable, but I strongly recommend enhancement. = - N/A. == MUST Items == [+/-] MUST: rpmlint must be run on every package. The output should be posted in the review. $ rpmlint * jreen.src: W: invalid-url Source0: jreen-0.1.0-20110901.tar.xz In your tarball reproduce script missed part of cd (or pushd) to jreen directory after 1st command. Please add it, now it doesn't work... Its minor and trivial to fix issue. jreen.i686: E: incorrect-fsf-address /usr/share/doc/jreen-0.1.0/GPL I've ask Ruslan, and that updated. Just pull changes and rebuild package. jreen-devel.i686: W: no-documentation jreen.spec: W: invalid-url Source0: jreen-0.1.0-20110901.tar.xz 4 packages and 1 specfiles checked; 1 errors, 3 warnings. [+] MUST: The package must be named according to the Package Naming Guidelines. [+] MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. [-] MUST: The package must meet the Packaging Guidelines. There sefew bundled libs. See below. Jreen must require libidn as runtime requirement (not BuildRequires). [+] MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. (In reply to comment #2) > Some files from this tarball are under GPLv3+. Except 3d party libraries I have not found files under diffirent licenses. So, Voler, please provide us exact files please. [+] MUST: The License field in the package spec file must match the actual license. [+] MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. [+] MUST: The spec file must be written in American English. [+/-] MUST: The spec file for the package MUST be legible. Please delete trailing spaces from each lines. Off course it is not stop issue, just estetic. [+] MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use md5sum for this task. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this. md5sum check is not available, but its seams identical. [+] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. http://koji.fedoraproject.org/koji/taskinfo?taskID=3322459 [=] MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in bugzilla, describing the reason that the package does not compile/build/work on that architecture. The bug number MUST be placed in a comment, next to the corresponding ExcludeArch line. [=] MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense. [=] MUST: The spec file MUST handle locales properly. This is done by using the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden. [+] MUST: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. [-] MUST: Packages must NOT bundle copies of system libraries. Package have bundled several libs (in directory 3rdparty), it is not allowed: jdns and simplesasl I've told with Ruslan about that and they say what jdns simple may be linked shared. And I think you should do that for jreen. Some more different situation with simplesasl. They said it copied from psi, and pidgin initialy also just contain that. For jreen it also taken as simple way. But it have errors and even not stable enought. Best way is use qca2-cirus-sasl plugin. It is released by same aouthora as qca2. So, you may wish ask qca2 maintainer ask to include that plugins and ship as subpackag(es), or pacjage it himself separately. Ruslan ready add into jreen needed compile switches to allow link it with shared libraries for Fedora (for that very-very big thankt to him!). [=] MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package. Without this, use of Prefix: /usr is considered a blocker. [+] MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. [+] MUST: A Fedora package must not list a file more than once in the spec file's %files listings. [+] MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example. [+/-] MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT). If you intend build it for EPEL too, add this. Otherwise it is not neccesary. [+/-] MUST: Each package must have a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). If you intend build it for EPEL too, add this. Otherwise it is not neccesary. Do you want package it for EPEL too?? [+] MUST: Each package must consistently use macros. [+] MUST: The package must contain code, or permissable content. Bundled libs mentioned before. Other content looks permissive for me. [=] MUST: Large documentation files must go in a -doc subpackage. (The definition of large is left up to the packager's best judgement, but is not restricted to size. Large can refer to either size or quantity). [+] MUST: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present. [+] MUST: Header files must be in a -devel package. [=] MUST: Static libraries must be in a -static package. [+/-] MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' (for directory ownership and usability). Again - for EPEL5 it must be added. [+] MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package. [+] MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name} = %{version}-%{release} [+] MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built. [=] MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. If you feel that your packaged GUI application does not need a .desktop file, you must put a comment in the spec file with your explanation. [+] MUST: Packages must not own files or directories already owned by other packages. The rule of thumb here is that the first package to be installed should own the files or directories that other packages may rely upon. This means, for example, that no package in Fedora should ever share ownership with any of the files or directories owned by the filesystem or man package. If you feel that you have a good reason to own a file or directory that another package owns, then please present that at package review time. [+] MUST: All filenames in rpm packages must be valid UTF-8. == SHOULD Items: == [=] SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [=] SHOULD: The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available. [+] SHOULD: The reviewer should test that the package functions as described. A package should not segfault instead of running, for example. I test link to it qutim. [+] SHOULD: If scriptlets are used, those scriptlets must be sane. This is vague, and left up to the reviewers judgement to determine sanity. [+] SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. [+] SHOULD: The placement of pkgconfig(.pc) files depends on their usecase, and this is usually for development purposes, so should be placed in a -devel pkg. A reasonable exception is that the main pkg itself is a devel tool not installed in a user runtime, e.g. gcc or gdb. [+] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself. So, as total the most important issue is package separate bundled libs. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
