Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=741945 Mo Morsi <mmo...@redhat.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #2 from Mo Morsi <mmo...@redhat.com> 2011-09-29 10:31:02 EDT --- Overall looks good, koji build is green http://koji.fedoraproject.org/koji/taskinfo?taskID=3388155 A few nits * BuildRoot is no longer needed and should be removed * same w/ the rm buildroot in the install and clean sections * Do we still need the exceptions for the older non-supported Fedora versions? I see these in the python guidelienss though so if they are required you can just ignore this note * is python-devel required as a build time dependency (again see this in the python guideliness, but this is my first python package review so I could be mistaken) >From what I can tell, everything else looks good, so APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
