Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=737550

--- Comment #2 from Bohuslav Kabrda <bkab...@redhat.com> 2011-10-14 04:07:32 
EDT ---
- Remove unused definitions (ruby_sitelib, ruby_sitearch)
- You don't need to specify the BuildRoot, see [1]
- Be a little more verbose in the description section (you can for example add
the line from README.mkd - "Minimalist way to build and publish gems using
Rake. Also build tarballs.").
- Consider introducing doc subpackage and moving %doc
%{gemdir}/doc/%{gemname}-%{version} into it.

- Next time, consider using gem2rpm, it saves a lot of work when packaging
rubygems.


[1] https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to