Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=670209 Bohuslav Kabrda <bkab...@redhat.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #5 from Bohuslav Kabrda <bkab...@redhat.com> 2011-10-14 05:00:44 EDT --- - The tests are compatible with RSpec 2, so I would recommend changing BR: rubygem(rspec) to rubygem(rspec-core). - Consider moving README.rdoc to doc subpackage. - The "%defattr(-, root, root, -)" lines can be omitted according to [1] So after you repair these few details, this package is APPROVED. [1] https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
