Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=751411 Thomas Spura <toms...@fedoraproject.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |toms...@fedoraproject.org --- Comment #1 from Thomas Spura <toms...@fedoraproject.org> 2011-11-04 15:51:04 EDT --- Some quick comments: - Are you already a packager? I couldn't find you in fas... - When you use a svn checkout, you need to promote it differently in %{version}: https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Non-Numeric_Version_in_Release - use global instead of define: https://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define - How did you generate the source? Either give a URL or add a comment, how you did the checkout. - What version of LGPL is this? LGPLv2+? (Didn't download sources because of the last issue above). - defattr looks odd and is not needed in Fedora (in el5 and below, if you want to branch for it) - The %changelog is missing. Please add a changelog everytime you change something and bump the release -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
