Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=751925 --- Comment #4 from Thibault North <thibault.no...@gmail.com> 2011-11-10 21:04:10 EST --- Hello Brendan, Thanks for your review. >The %check seems to >take an awfully long time, and there are a number of test directories >installed. >I'm just wondering if they're really necessary. I don't really know. For python-numexpr, I was suggested to add these kind of checks. I guess it will help the tracking of some bugs if tests fail at a rebuild. >You could consider a separate doc package also for the examples and >documentation, but that's just a suggestion. Full review below, I'll wait for >your reply before passing. Done. >[!] Be licensed with a Fedora approved license and meet the Licensing >Guidelines >*** You just need to specify the lrucache.py is licensed under AFL License is set to BSD and AFL: is that good enough? >[?] Has BuildRequires: python-setuptools-devel > >I'm really not sure if this is still required? I don't know. Other python- packages I have seen don't have it. >[!] All build dependencies must be listed in BuildRequires >*** perhaps python2-devel rather than python-devel, although this is rather >cosmetic Fixed. Thanks again, Thibault -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
