Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=744339 --- Comment #18 from Richard Shaw <hobbes1...@gmail.com> 2011-11-16 18:44:43 EST --- (In reply to comment #17) > ad 2) I have checked difference between COPYING, NOTES and README files under > libdieharder/ directory > and the top level directory and it seems to me like that COPYING, NOTES and > README files under libdieharder/ directory are just older versions of the > files > in the top level. That may be, but one thing I noticed when doing a diff of the two COPYING files: $ diff -u COPYING libdieharder/COPYING --- COPYING 2011-10-14 08:41:37.000000000 -0500 +++ libdieharder/COPYING 2011-10-14 08:41:37.000000000 -0500 @@ -1,8 +1,8 @@ -$Id: COPYING 215 2006-07-25 18:57:50Z rgb $ +$Id: COPYING 221 2006-08-16 22:43:03Z rgb $ License is granted to build or use the accompanying software: - dieharder + libdieharder according to the following standard Gnu General Public License or any later versions, with the one minor "Beverage" modification listed below. --- The files specifically callout dieharder and libdieharder. I'm not familiar enough with the legalease of software licenses but the safest thing to do is how I set things up in my spec. Hopefully the developer will clarify. As far as the manual goes, since it has instructions for the binary, I would keep it in the main package. I think you're pretty much done, just change the documentation as necessary depending on what the developer says. I already did the review but it's on my work computer so instead of doing it all over again I'll approve your package first thing in the morning! Richard -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
