Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=754023 --- Comment #1 from Michael Schwendt <mschwe...@gmail.com> 2011-11-19 14:28:12 EST --- * https://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage > %patch0 -p1 -b .desktop Caution! The '-b .desktop' option creates a copy of the unpatched file with '.desktop' at its end of the file name. Therefore it bears the risk of creating confusion for anything that would work on a '*.desktop' wildcard. Safer would be something less ambiguous, such as: %patch0 -p1 -b .desktop-file > %{_datadir}/%{name}/tagpresets Just by looking at the spec file %files section, this entry is evidence that the %_datadir/%name directory is not included: https://fedoraproject.org/wiki/Packaging:UnownedDirectories > %{_mandir}/man1/%{name}-*.1.* > %{_mandir}/man1/download_osm.1.* > %{_mandir}/man1/osm2places.1.* > %{_mandir}/man1/%{name}.1.* > %{_mandir}/man1/get_maprect.1.* > %{_mandir}/man1/simplify-gps.1.* Looks funny, but no blocker here. Only comments: - Manual pages are compressed by rpmbuild, so you could append '1*' instead of '1.*' to also handle the case of packaging uncompressed man pages. - Listing individual file names with only limited use of macros and '*' wildcards can be beneficial in some cases (and elsewhere in the %files section, e.g. as a guard of the type "I want this particular file to exist"), but is it important here to enter specific file names? This wouldn't be convenient with packages that include many more man pages. Also, your usage of '%{name}-*' in the %files section implies that any files matching that pattern can go missing or return in arbitrary updates of the package without terminating the build. Are the other manuals much more important as not to terminate the build? Would %{_mandir}/man1/*.1* not be good enough? * Format string warnings in the build log on x86_64! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
