Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=755890 --- Comment #4 from T.C. Hollingsworth <tchollingswo...@gmail.com> 2011-11-22 14:55:42 EST --- RPMLint output is not clean: > $ rpmlint ./snap-0.5-2.fc15.src.rpm > snap.src: E: summary-too-long C A modular system backup/restore utility which > uses the native package management system Please keep lines under 40 characters. > snap.src:34: W: macro-in-comment %check > snap.src:35: W: macro-in-comment %{__python} Please escape RPM Macros in comments (e.g. %%check) > snap.src: W: invalid-url Source0: http://mo.morsi.org/files/snap/snap-0.5.tgz > HTTP Error 404: Not Found The Source0 URL 404s. Please fix it. (Be it server-side or in the specfile. ;-) > 1 packages and 0 specfiles checked; 1 errors, 3 warnings. > $ rpmlint snap-0.5-2.fc16.noarch.rpm > snap.noarch: E: summary-too-long C A modular system backup/restore utility > which uses the native package management system See above. > snap.noarch: E: non-executable-script > /usr/lib/python2.7/site-packages/snap/backends/services/adapters/httpd.py > 0644L /usr/bin/python > snap.noarch: E: non-executable-script > /usr/lib/python2.7/site-packages/snap/filemanager.py 0644L /usr/bin/python > snap.noarch: E: non-executable-script > /usr/lib/python2.7/site-packages/snap/metadata/service.py 0644L > /usr/bin/python > snap.noarch: E: non-executable-script > /usr/lib/python2.7/site-packages/snap/snapshottarget.py 0644L /usr/bin/python > snap.noarch: E: non-executable-script > /usr/lib/python2.7/site-packages/snap/backends/files/sapt.py 0644L > /usr/bin/python > snap.noarch: E: non-executable-script > /usr/lib/python2.7/site-packages/snap/backends/services/mock.py 0644L > /usr/bin/python > snap.noarch: E: non-executable-script > /usr/lib/python2.7/site-packages/snap/backends/services/adapters/iptables.py > 0644L /usr/bin/python > snap.noarch: E: non-executable-script > /usr/lib/python2.7/site-packages/snap/backends/packages/syum.py 0644L > /usr/bin/python > snap.noarch: E: non-executable-script > /usr/lib/python2.7/site-packages/snap/config.py 0644L /usr/bin/python > snap.noarch: E: non-executable-script > /usr/lib/python2.7/site-packages/snap/backends/packages/mock.py 0644L > /usr/bin/python > snap.noarch: E: non-executable-script > /usr/lib/python2.7/site-packages/snap/backends/repos/sapt.py 0644L > /usr/bin/python > snap.noarch: E: non-executable-script > /usr/lib/python2.7/site-packages/snap/__init__.py 0644L /usr/bin/python > snap.noarch: E: non-executable-script > /usr/lib/python2.7/site-packages/snap/crypto.py 0644L /usr/bin/python > snap.noarch: E: non-executable-script > /usr/lib/python2.7/site-packages/snap/backends/services/adapters/mysql.py > 0644L /usr/bin/python > snap.noarch: E: non-executable-script > /usr/lib/python2.7/site-packages/snap/backends/packages/win.py 0644L > /usr/bin/python > snap.noarch: E: non-executable-script > /usr/lib/python2.7/site-packages/snap/backends/services/dispatcher.py 0644L > /usr/bin/python > snap.noarch: E: non-executable-script > /usr/lib/python2.7/site-packages/snap/backends/services/adapters/mock.py > 0644L /usr/bin/python > snap.noarch: E: non-executable-script > /usr/lib/python2.7/site-packages/snap/backends/services/linuxdispatcher.py > 0644L /usr/bin/python > snap.noarch: E: non-executable-script > /usr/lib/python2.7/site-packages/snap/backends/files/win.py 0644L > /usr/bin/python > snap.noarch: E: non-executable-script > /usr/lib/python2.7/site-packages/snap/metadata/sfile.py 0644L /usr/bin/python > snap.noarch: E: non-executable-script > /usr/lib/python2.7/site-packages/snap/backends/repos/mock.py 0644L > /usr/bin/python > snap.noarch: E: non-executable-script > /usr/lib/python2.7/site-packages/snap/backends/services/adapters/postgresql.py > 0644L /usr/bin/python > snap.noarch: E: non-executable-script > /usr/lib/python2.7/site-packages/snap/metadata/snapfile.py 0644L > /usr/bin/python > snap.noarch: E: non-executable-script > /usr/lib/python2.7/site-packages/snap/exceptions.py 0644L /usr/bin/python > snap.noarch: E: non-executable-script > /usr/lib/python2.7/site-packages/snap/metadata/package.py 0644L > /usr/bin/python > snap.noarch: E: non-executable-script > /usr/lib/python2.7/site-packages/snap/backends/services/windowsdispatcher.py > 0644L /usr/bin/python > snap.noarch: E: non-executable-script > /usr/lib/python2.7/site-packages/snap/backends/repos/syum.py 0644L > /usr/bin/python > snap.noarch: E: non-executable-script > /usr/lib/python2.7/site-packages/snap/osregistry.py 0644L /usr/bin/python > snap.noarch: E: non-executable-script > /usr/lib/python2.7/site-packages/snap/backends/files/mock.py 0644L > /usr/bin/python > snap.noarch: E: non-executable-script > /usr/lib/python2.7/site-packages/snap/backends/files/syum.py 0644L > /usr/bin/python > snap.noarch: E: non-executable-script > /usr/lib/python2.7/site-packages/snap/backends/packages/sapt.py 0644L > /usr/bin/python > snap.noarch: E: non-executable-script > /usr/lib/python2.7/site-packages/snap/backends/services/adapters/iis.py 0644L > /usr/bin/python > snap.noarch: E: non-executable-script > /usr/lib/python2.7/site-packages/snap/callback.py 0644L /usr/bin/python Consider removing the unnecessary shebang lines from these files. >> snap.noarch: W: non-conffile-in-etc /etc/snap.conf Please mark this file with %config or %config(noreplace). See http://fedoraproject.org/wiki/Packaging:Guidelines#Configuration_files for more information. > snap.noarch: W: no-manual-page-for-binary gsnap > snap.noarch: W: no-manual-page-for-binary snaptool You might want to rename the manpage to snaptool.1 to match the binary it describes. gsnap is graphical and doesn't strictly require a manpage, but if it has advanced command line options it might be worthwhile to write one anyway. > 1 packages and 0 specfiles checked; 34 errors, 3 warnings. It seems your package is missing dependencies. gsnap fails on my system with the following error: > Traceback (most recent call last): > File "/usr/bin/gsnap", line 33, in <module> > from gi.repository import Gtk, Gdk, GObject > ImportError: No module named gi.repository Additionally, you also might want to consider packaging the Gtk interface in a "snap-gtk" subpackage so command-line only users don't need to install Gtk dependencies. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
