Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=646606

Peter Borsa <peter.bo...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review?

--- Comment #14 from Peter Borsa <peter.bo...@gmail.com> 2011-11-23 17:03:05 
EST ---
Jon,

I tried to rebuild this package on my F16 box and got a few issues, please fix
these.


$ rpmlint drupal6-workspace.spec
../SRPMS/drupal6-workspace-1.4-0.rc1.fc16.src.rpm
../RPMS/noarch/drupal6-workspace-1.4-0.rc1.fc16.noarch.rpm 
drupal6-workspace.noarch: W: obsolete-not-provided drupal-workspace
drupal6-workspace.noarch: E: incorrect-fsf-address
/usr/share/doc/drupal6-workspace-1.4/LICENSE.txt
2 packages and 1 specfiles checked; 1 errors, 1 warnings.

Plus, I'd define a "prerelease" macro so you can get better URLs like below.

"Source0:  
http://ftp.drupal.org/files/projects/imagecache-6.x-%{version}-%{prerelease}.tar.gz";

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to