Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=754137

--- Comment #15 from Steve Traylen <steve.tray...@cern.ch> 2011-11-30 19:08:01 
EST ---

1)

Changelog does not match release, and the spec file has changed 
with no corresponding changelog entry reflecting the change made in the
.spec file.

Please run rpmlint at every release:

$ rpmlint ../RPMS/x86_64/nagios-plugins-bdii-*
nagios-plugins-bdii.x86_64: W: incoherent-version-in-changelog 1.0.12-1.el6
['1.0.12-2.el6', '1.0.12-2']
nagios-plugins-bdii.x86_64: W: no-documentation

2)
Can you take a look at or report upstream the compilation warnings,
not a requirement but worth following up.

rc/check_bdii_entries.c: In function 'main':
src/check_bdii_entries.c:168: warning: implicit declaration of function
'ldap_init'
src/check_bdii_entries.c:168: warning: assignment makes pointer from integer
without a cast
....

2)
The %description is rather terse and includes BDII which is not described
anywhere and is not obvious to people in general I believe.

3)
The  tar ball in the .src.rpm does not match the instructions to create it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to