Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=760897

Parag AN(पराग) <panem...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panem...@gmail.com
         AssignedTo|nob...@fedoraproject.org    |panem...@gmail.com
               Flag|                            |fedora-review+

--- Comment #3 from Parag AN(पराग) <panem...@gmail.com> 2011-12-08 00:01:45 EST 
---
Review:

+ koji scratch build in f17
->http://koji.fedoraproject.org/koji/taskinfo?taskID=3573455

+ rpmlint on rpms gave
libeasyfc.src: W: spelling-error Summary(en_US) fontconfig -> configuration
libeasyfc.src: W: spelling-error %description -l en_US fontconfig ->
configuration
libeasyfc.x86_64: W: spelling-error Summary(en_US) fontconfig -> configuration
libeasyfc.x86_64: W: spelling-error %description -l en_US fontconfig ->
configuration
libeasyfc-devel.x86_64: W: spelling-error %description -l en_US fontconfig ->
configuration
libeasyfc-gobject.x86_64: W: spelling-error %description -l en_US fontconfig ->
configuration
libeasyfc-gobject-devel.x86_64: W: spelling-error %description -l en_US
fontconfig -> configuration
5 packages and 0 specfiles checked; 0 errors, 7 warnings.

+ source verified with upstream as
3e130155e357f26bb8112dad10ac1eca2d8ce608  libeasyfc-0.1.tar.bz2
3e130155e357f26bb8112dad10ac1eca2d8ce608  ../SOURCES/libeasyfc-0.1.tar.bz2

suggestions:
1) If not planning for RHEL then remove
  a) buildroot
  b) %clean section
  c) cleaning of buildroot in %install
  d) %defattr(-, root, root, -)

2) I think only base package should add docs files in %doc and not subpackages.
See
http://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Subpackage_Licensing

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to