Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=760177

--- Comment #6 from Volker Fröhlich <volke...@gmx.at> 2011-12-12 13:50:45 EST 
---
%{_libexecdir}/%{name}/* --> %{_libexecdir}/%{name}

That takes ownership of the directory and everything below. The configuration
directory is without an owner as well.

I'd suggest to run the unit tests in a check section, but not to install them,
if you don't have a compelling reason. And if so, rather create a sub-package.

You need BuildRequires: systemd-units, see
http://fedoraproject.org/wiki/Packaging:Systemd#Filesystem_locations

Why don't you have a %postun scriplet? See
http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd

You can use %{_sharedstatedir} instead of %{_var}/lib (twice)

The %attr is not necessary for the configuration file. It defaults to exactly
that. In the case of the service file: Pleas use install -p -m644. That gives
you the proper permissions plus preserves the timestamp.

The configuration files should preserve their original timestamp on installing.
I wonder, if the other sample configuration files in the tarball could act as
further documentation.

(Please delete the empty line at the very bottom.)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to