Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=767226

Parag AN(पराग) <panem...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panem...@gmail.com
         AssignedTo|nob...@fedoraproject.org    |panem...@gmail.com
               Flag|                            |fedora-review+

--- Comment #3 from Parag AN(पराग) <panem...@gmail.com> 2011-12-14 04:26:56 EST 
---
Review:
+ koji scratch build ->
http://koji.fedoraproject.org/koji/taskinfo?taskID=3582272

+ Source generated from svn revision 12 so no verification with upstream here

+ rpmlint on rpms gave
scannotation.noarch: W: spelling-error %description -l en_US classpath -> class
path, class-path, classmate
scannotation.noarch: W: spelling-error %description -l en_US apis -> pis,
apish, apes
scannotation.src: W: spelling-error %description -l en_US classpath -> class
path, class-path, classmate
scannotation.src: W: spelling-error %description -l en_US apis -> pis, apish,
apes
scannotation.src: W: invalid-url Source0: scannotation-1.0.3.Final.tar.xz
scannotation-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs -> Java
docs, Java-docs, Avocados
3 packages and 0 specfiles checked; 0 errors, 6 warnings.

+ rest looks ok in specfile

Suggestions:
1) you should preserve the timestamps of files being installed using -p. so
replace
cp %SOURCE1 .
with 
cp -p %SOURCE1 .

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to