Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=761474

Parag AN(पराग) <panem...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #1 from Parag AN(पराग) <panem...@gmail.com> 2011-12-14 05:11:52 EST 
---
Review:

+ koji scratch build f17
->http://koji.fedoraproject.org/koji/taskinfo?taskID=3583991

+ rpmlint on rpms gave
ibus-european-table.src: W: file-size-mismatch ibus-european-table-1.1.0.tar.gz
= 275240,
https://github.com/gnuman/fedora_package/blob/master/ibus-european-table-1.1.0.tar.gz
= 25090
ibus-european-table.noarch: W: devel-file-in-non-devel-package
/usr/share/pkgconfig/ibus-european-table.pc
ibus-european-table.noarch: W: no-manual-page-for-binary
ibus-european-table-createdb
ibus-european-table.src: W: file-size-mismatch ibus-european-table-1.1.0.tar.gz
= 275240,
https://github.com/gnuman/fedora_package/blob/master/ibus-european-table-1.1.0.tar.gz
= 25090
3 packages and 0 specfiles checked; 0 errors, 4 warnings.
==> I see that if source is downloaded using wget then size mismatch
happens.you can optionally just put the name of tarball instead of URL.

+ Source verified with upstream as 
00ef1ef876878ac03c3978d7f1ec75f3df287907  ibus-european-table-1.1.0.tar.gz
00ef1ef876878ac03c3978d7f1ec75f3df287907 
../SOURCES/ibus-european-table-1.1.0.tar.gz


Suggestions:
1) you don't need to write following line in spec now in Fedora
%defattr(-,root,root,-)

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to