Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=710904 --- Comment #9 from Thomas Sailer <t.sai...@alumni.ethz.ch> 2011-12-17 07:30:50 EST --- Thanks for the review Jussi! Spec URL: http://sailer.fedorapeople.org/octave-communications.spec SRPM URL: http://sailer.fedorapeople.org/octave-communications-1.1.0-2.fc16.src.rpm Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3590036 I've changed the spec file according to your comments. > Also, if you give executable rights to the source files, you don't need to run > chmod in the spec. As you noticed, rpmlint doesn't like that, so I kept the chmod. > Please get rid of the %attr lines, they shouldn't be necessary. Ok, I added chmod statements in the install section and dropped the %attr's. Two .m files are distributed with the executable bit set, so either chmod or %attr is necessary to silence rpmlint. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
