Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=769697 Jussi Lehtola <jussi.leht...@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jussi.leht...@iki.fi AssignedTo|nob...@fedoraproject.org |jussi.leht...@iki.fi Flag| |fedora-review? --- Comment #2 from Jussi Lehtola <jussi.leht...@iki.fi> 2011-12-27 08:00:35 EST --- This looks useful, but the spec file looks like it's been written in quite a hurry and needs some working over. ** nested.noarch: W: summary-ended-with-dot C Nested is a specialized editor focused on creating structured documents such as reports, publications, presentations, books, etc. nested.noarch: E: summary-too-long C Nested is a specialized editor focused on creating structured documents such as reports, publications, presentations, books, etc. nested.noarch: W: name-repeated-in-summary C Nested nested.noarch: E: description-line-too-long C Nested is a specialized editor focused on creating structured documents such as reports, publications, presentations, books, etc. It is designed to help the user concentrate on writing content without been distracted by format or markup. It offers a rich WYSIWYM interface where the user writes plain text with a lightweight markup language. nested.noarch: W: incoherent-version-in-changelog 1.2.2-2 ['1.2.2-3.fc16', '1.2.2-3'] nested.noarch: W: invalid-license GPL2+ nested.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/nested/txt2tags.py 0644L /usr/bin/env nested.noarch: W: no-manual-page-for-binary nested nested.src: W: summary-ended-with-dot C Nested is a specialized editor focused on creating structured documents such as reports, publications, presentations, books, etc. nested.src: E: summary-too-long C Nested is a specialized editor focused on creating structured documents such as reports, publications, presentations, books, etc. nested.src: W: name-repeated-in-summary C Nested nested.src: E: description-line-too-long C Nested is a specialized editor focused on creating structured documents such as reports, publications, presentations, books, etc. It is designed to help the user concentrate on writing content without been distracted by format or markup. It offers a rich WYSIWYM interface where the user writes plain text with a lightweight markup language. nested.src: W: invalid-license GPL2+ 2 packages and 0 specfiles checked; 5 errors, 8 warnings. Fix these. Summary should be something like A specialized editor focused on creating structured documents and the description should be line-wrapped. License tag should read GPLv2+. ** Drop the tarball_name macro which isn't used anywhere. ** Drop explicit Requires: python. ** Change Requires: texlive texlive-latex to Requires: tex(latex) which is the recommended form. ** Please buildrequire gettext-devel instead of plain gettext. ** Drop the if clause in %if ! (0%{?fedora} > 12 || 0%{?rhel} > 5) %{!?python_sitelib: %global python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib())")} %endif since it does not make any sense. The declaration of python_sitelib is enough. ** Drop the --record=INSTALLED_FILES statement from the install, as it isn't (and should not be) used. ** Please document the l10 stuff. ** Please separate the %clean section from the %install section, or you can drop it altogether. ** Please be more verbose in %files - there's no need to use wildcards. %{python_sitelib}/nested/ %{python_sitelib}/nested-%{version}-py*.egg-info %{_bindir}/nested Also, if you intend to build for EPEL-5, you need the %defattr line. ** CHANGELOG.txt and LICENSE.txt are missing from %doc. ** These are my initial comments. When you have addressed these I will perform the full review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
