Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=770986 --- Comment #3 from Mamoru Tasaka <mtas...@fedoraproject.org> 2012-01-01 03:49:06 EST --- For -2: * Build failure - -2 won't build - %check fails because ruby could not find kgio_ext.so (note that this is installed under %buildroot%ruby_sitearch at %check, not under %buildroot%ruby_sitearch/kgio, i.e. the last "kgio" part is not needed) http://koji.fedoraproject.org/koji/taskinfo?taskID=3612585 * Patches - %check is not build phase and if you want to apply patches *on the files to be packaged*, I think it should be done on %prep or %build or %install. (Sometimes you may want to disable %check due to some reason, and for this reason files to be packaged should not be modified on %check) Note that sometimes I apply some patches on %check, for files not under %buildroot. I usually do test programs under %_builddir (normally ${HOME}/rpmbuild/BUILD) to make it sure that files under %buildroot are not modified during %check phase. * Unused macro - %ruby_sitelib macro is defined in the spec file but is used nowhere. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
