Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=770740

adev <ade...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ade...@gmail.com

--- Comment #3 from adev <ade...@gmail.com> 2012-01-06 11:25:57 EST ---
Hi, 

Quick comments about your spec file :

- use the %{_isa} macro for your "Requires" dependencies on binary packages.

- "-DCMAKE_INSTALL_PREFIX=/usr" is useless, it is already included in the
%cmake macro

- %{_libdir} could be used instead of /usr/lib64/ with your cmake command

- same with %{_includedir} instead of /usr/include

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to