Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=772406

Volker Fröhlich <volke...@gmx.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |volke...@gmx.at

--- Comment #2 from Volker Fröhlich <volke...@gmx.at> 2012-01-08 07:11:40 EST 
---
Use Fedora's optflags when compiling. You can gather some inspiration from
https://bugzilla.redhat.com/show_bug.cgi?id=513541

http://fedoraproject.org/wiki/PackagingGuidelines#Compiler_flags

Please use the %{_bindir} macro instead of "/usr/bin" and the name macro for
"cpulimit". Also use it in Source0.

Defattr is obsolete.

If you don't go for EPEL 5, remove the buildroot definition, the clean section
and the rm in the install section.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to