Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=759941

Mattia Verga <mattia.ve...@tiscali.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #4 from Mattia Verga <mattia.ve...@tiscali.it> 2012-01-08 07:50:13 
EST ---
- rpmlint checks return:
spatialite-gui.x86_64: W: no-manual-page-for-binary spatialite_gui
3 packages and 1 specfiles checked; 0 errors, 1 warnings.

Warning can be ignored: OK

- naming guidelines and .spec file name: OK
- packaging guidelines: OK
- license: OK (GPLv3), in %doc
- spec file legible, in am. english: OK
- source matches upstream: OK
- package compiles on (i686/x86_64): OK
+ Build Requires / Requires: NOTE 1
- no locales
- no libraries
- not relocatable
- no directories created
- no duplicate files
- file permissions: OK
- macros: OK
- code/content: OK
- no need for -docs
- nothing in %doc affects runtime
- no headers / no need for -devel
- .desktop file: OK
- ownership: OK
- filenames: OK

NOTES:
--------------
1: The required packages are automatically added by rpm, however I'm thinking
about the opportunity to specify a 'require: libspatialite', since this package
has no functionality without it. What do you think?

That is not a blocker, so I mark this as APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to