Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=772362

--- Comment #8 from Hans de Goede <hdego...@redhat.com> 2012-01-19 09:42:28 EST 
---
Good news, I've got the entire sigil dep chain building, running and ready for
review now using system libraries for everything except for tidylib.

If I've understood things correctly the embedded tidylib copy has some
modifications which sigil needs, but which we should be able to get upstream.
So my suggestion is that we move forward with an embedded tidylib copy for now,
while working with tidylib upstream to get the changes upstream. Then once
these
are upstream we can move to using the system version.

Here are all the review bugs:
ZipArchive, bug 773313
FlightCrew, bug 783151
sigil, this bug :)

Here is the version of sigil using a system version of FlightCrew and
XercesExtensions (part of FlightCrew):

Spec URL: http://people.fedoraproject.org/~jwrdegoede/sigil.spec
SRPM URL:
http://people.fedoraproject.org/~jwrdegoede/sigil-0.4.2-3.fc15.src.rpm

Dan, note that I've respun all your patches for both FlightCrew and sigil
itself, they added new lines in unix format to DOS format textfiles, making the
resulting format mixed-format wrt their newline use. In 2 cases I've also done
some small other fixes, see the commit messages inside the patches.

Also noteworthy is that I ended up not building zipios as a shared library as
it is only used by FlightCrew I've left it embedded in libFlightCrew.so .

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to