Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=741626

--- Comment #7 from Jussi Lehtola <jussi.leht...@iki.fi> 2012-01-21 13:21:57 
EST ---
(In reply to comment #6)
> I take this one. The package looks good to me -- I just recommend to 
> explicitly
> remove cenmass.o in %prep in order to prevent linking this object file.

Done.

> Also, upstream has released a new version of packmol. Maybe you'd like to
> update the package. The license headers are still missing but there's a file
> LICENSE present now which refers to GPLv2 only while COPYING still contains 
> the
> GPLv3 license text. Upstream should definitely fix this. The license tag GPL+
> is nonetheless correct, though.

Done; but the correct license tag is now GPLv2.

http://theory.physics.helsinki.fi/~jzlehtol/rpms/packmol.spec
http://theory.physics.helsinki.fi/~jzlehtol/rpms/packmol-1.1.2.017-1.fc16.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to