Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=737293 Bohuslav Kabrda <bkab...@redhat.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bkab...@redhat.com --- Comment #2 from Bohuslav Kabrda <bkab...@redhat.com> 2012-01-25 07:12:25 EST --- Just a few quick notes: - You have the Provides: Django = %{name}-%{version}-%{release} but according to [1], it should only be Django = %{version}-%{release}. - According to the same guideline, Obsoletes should be Django < 1.3.1-3 (so do not use the macros, but hardcode the concrete versions that you Obsolete - if you would increase the version, the Obsoletes would change with macro, which is not what you want, you want to Obsolete exactly the versions lower than 1.3.1-3). - AFAIK Django ships with lots of unit tests. You should probably run them in %check section to uncover possible problems and report them upstream. - The renaming of Django modules is currently being discussed on fedora python-devel mailing list [2], you might want to take a look there. - I'd be happy to take the review, but I would recommend against getting the renamed package into F17, because the devel freeze is comming and it would be hard to rename all the packages. Let's leave it to the next Rawhide/F18, then I'll take it. What do you think? [1] http://fedoraproject.org/wiki/Packaging:Guidelines#Renaming.2FReplacing_Existing_Packages [2] http://lists.fedoraproject.org/pipermail/python-devel/2012-January/000335.html -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
