Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=784201 --- Comment #3 from Bohuslav Kabrda <bkab...@redhat.com> 2012-01-25 08:30:34 EST --- (In reply to comment #2) > * Should use vim-common > - It seems that instead of requiring vim and vim-filesystem, you should use > vim-common package. > Done. > * Do not own the directories owned by vim-filesystem. > - According to FPG: > > Directory ownership is a little more complex than file ownership. Packages > must own all directories they put files in, except for: > > any directories owned by the filesystem, man, or other explicitly > created > -filesystem packages > > - You should own just content of the following directories, not the > directories itself: > > %{vimfiles_root}/doc > %{vimfiles_root}/plugin > %{vimfiles_root}/syntax > Done. > > * You shoud preserve the file timestamps > - Please use cp -a or install command > Huh, thought i did that... Done. > * Package naming > - I am unsure it the package name is really correct. Could you please check > with upstream if they are going to stick with "nerdtree" from now? Will do. I will put the new SPEC/SRPM as soon as I will deal with this naming issue. Thank you! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
