Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=784047 Petr Pisar <ppi...@redhat.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #4 from Petr Pisar <ppi...@redhat.com> 2012-01-26 03:48:46 EST --- Spec file changes: --- perl-HTTP-ProxyAutoConfig.spec.old 2012-01-23 17:28:04.000000000 +0100 +++ perl-HTTP-ProxyAutoConfig.spec 2012-01-26 09:38:57.095000001 +0100 @@ -6,6 +6,7 @@ Group: Development/Libraries URL: http://search.cpan.org/dist/HTTP-ProxyAutoConfig/ Source0: http://www.cpan.org/authors/id/M/MA/MACKENNA/HTTP-ProxyAutoConfig-%{version}.tar.gz +Source1: LICENSE.correspondence BuildArch: noarch BuildRequires: perl(ExtUtils::MakeMaker) >= 6.56 %{?_with_network_tests: @@ -26,6 +27,7 @@ %prep %setup -q -n HTTP-ProxyAutoConfig-%{version} +cp %{SOURCE1} . %build %{__perl} Makefile.PL INSTALLDIRS=vendor @@ -42,7 +44,7 @@ %{?_with_network_tests: make test} %files -%doc Changes examples README +%doc Changes examples README LICENSE.correspondence %{perl_vendorlib}/* %{_mandir}/man3/* > FIX: Change license to `GPLv2+ or Artistic' or clarify with upstream. Upstream confirmed the correct license is GPLv1+ or Artistic. Ok. $ rpmlint perl-HTTP-ProxyAutoConfig.spec ../SRPMS/perl-HTTP-ProxyAutoConfig-0.3-1.fc17.src.rpm ../RPMS/noarch/perl-HTTP-ProxyAutoConfig-0.3-1.fc17.noarch.rpm perl-HTTP-ProxyAutoConfig.src: W: spelling-error Summary(en_US) pac -> PAC, cap, pa perl-HTTP-ProxyAutoConfig.src: W: spelling-error Summary(en_US) wpad -> woad, wad, pad perl-HTTP-ProxyAutoConfig.src: W: spelling-error Summary(en_US) dat -> DAT, tad, sat perl-HTTP-ProxyAutoConfig.src: W: spelling-error %description -l en_US pac -> PAC, cap, pa perl-HTTP-ProxyAutoConfig.src: W: strange-permission LICENSE.correspondence 0600L perl-HTTP-ProxyAutoConfig.noarch: W: spelling-error Summary(en_US) pac -> PAC, cap, pa perl-HTTP-ProxyAutoConfig.noarch: W: spelling-error Summary(en_US) wpad -> woad, wad, pad perl-HTTP-ProxyAutoConfig.noarch: W: spelling-error Summary(en_US) dat -> DAT, tad, sat perl-HTTP-ProxyAutoConfig.noarch: W: spelling-error %description -l en_US pac -> PAC, cap, pa perl-HTTP-ProxyAutoConfig.noarch: E: non-readable /usr/share/doc/perl-HTTP-ProxyAutoConfig-0.3/LICENSE.correspondence 0600L 2 packages and 1 specfiles checked; 1 errors, 9 warnings. TODO: Change LICENSE.correspondence mode to 0644. Package builds in F17 (http://koji.fedoraproject.org/koji/taskinfo?taskID=3733971). Ok. Please correct all `TODO' items before building this package. Resolution: Package APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
