Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=761319 --- Comment #19 from Sébastien Willmann <sebastien.willm...@gmail.com> 2012-01-29 12:05:59 EST --- Package Review ============== Key: - = N/A x = Pass ! = Fail ? = Not evaluated fedora-review generates the following section for C/C++, but it's still relevant for this package. ==== C/C++ ==== [x]: MUST ldconfig called in %post and %postun if required. [x]: MUST Package does not contain any libtool archives (.la) [x]: MUST Package does not contain kernel modules. [!]: MUST Package contains no static executables. [x]: MUST Rpath absent or only used for internal libs. [x]: MUST Package is not relocatable. [x]: MUST Development .so files in -devel subpackage, if present. [!]: MUST Static libraries in -static subpackage, if present. ==== Generic ==== [x]: MUST Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: MUST Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: MUST All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: MUST Buildroot is not present Note: Unless packager wants to package for EPEL5 this is fine [x]: MUST Package contains no bundled libraries. [x]: MUST Changelog in prescribed format. [x]: MUST Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: Clean would be needed if support for EPEL is required [x]: MUST Sources contain only permissible code or content. [x]: MUST Each %files section contains %defattr if rpm < 4.4 Note: Note: defattr macros not found. They would be needed for EPEL5 [x]: MUST Macros in Summary, %description expandable at SRPM build time. [x]: MUST Package requires other packages for directories it uses. [x]: MUST Package uses nothing in %doc for runtime. [x]: MUST Package is not known to require ExcludeArch. [x]: MUST Permissions on files are set properly. [x]: MUST Package does not contain duplicates in %files. [x]: MUST Spec file lacks Packager, Vendor, PreReq tags. [x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf would be needed if support for EPEL5 is required [x]: MUST If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [!]: MUST License field in the package spec file matches the actual license. COPYING says that the license is LGPLv3, but the source code says LGPLv2.1+. The oldest version should be specified. [x]: MUST License file installed when any subpackage combination is installed. [x]: MUST Package consistently uses macros (instead of hard-coded directory names). [!]: MUST Package meets the Packaging Guidelines. [x]: MUST Package is named according to the Package Naming Guidelines. [x]: MUST Package does not generates any conflict. [x]: MUST Package obeys FHS, except libexecdir and /usr/target. [x]: MUST Package must own all directories that it creates. [x]: MUST Package does not own files or directories owned by other packages. [?]: MUST Package installs properly. Couldn't build the package for fedora 16 [!]: MUST Requires correct, justified where necessary. Explain why you use explicit requires [!]: MUST Rpmlint output is silent. rpmlint gtkd-1.5.1-15.20120113svn920.fc17.src.rpm gtkd.src: I: enchant-dictionary-not-found en_US gtkd.src: I: enchant-dictionary-not-found fr gtkd.src: W: invalid-url Source0: gtkd-20120113svn920.tar.xz 1 packages and 0 specfiles checked; 0 errors, 1 warnings. rpmlint gtkd-devhelp-1.5.1-15.20120113svn920.fc17.noarch.rpm gtkd-devhelp.noarch: I: enchant-dictionary-not-found en_US gtkd-devhelp.noarch: I: enchant-dictionary-not-found fr gtkd-devhelp.noarch: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings. rpmlint gtkd-geany-tags-1.5.1-15.20120113svn920.fc17.noarch.rpm gtkd-geany-tags.noarch: I: enchant-dictionary-not-found en_US gtkd-geany-tags.noarch: I: enchant-dictionary-not-found fr gtkd-geany-tags.noarch: W: no-documentation gtkd-geany-tags.noarch: E: script-without-shebang /usr/share/geany/tags/gtkd.d.tags 1 packages and 0 specfiles checked; 1 errors, 1 warnings. rpmlint gtkd-devel-1.5.1-15.20120113svn920.fc17.i686.rpm gtkd-devel.i686: I: enchant-dictionary-not-found en_US gtkd-devel.i686: I: enchant-dictionary-not-found fr gtkd-devel.i686: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings. rpmlint gtkd-1.5.1-15.20120113svn920.fc17.i686.rpm gtkd.i686: I: enchant-dictionary-not-found en_US gtkd.i686: I: enchant-dictionary-not-found fr gtkd.i686: W: unstripped-binary-or-object /usr/lib/libgtkdsv.so.1.5.1 gtkd.i686: W: unstripped-binary-or-object /usr/lib/libgtkdgl.so.1.5.1 gtkd.i686: W: unstripped-binary-or-object /usr/lib/libgtkd.so.1.5.1 1 packages and 0 specfiles checked; 0 errors, 3 warnings. [x]: MUST Sources used to build the package match the upstream source, as provided in the spec URL. No differences found with diff -r [!]: MUST Spec file is legible and written in American English. Some sentences in the comments need to be corrected [x]: MUST Spec file name must match the spec package %{name}, in the format %{name}.spec. [-]: MUST Package contains a SysV-style init script if in need of one. [x]: MUST File names are valid UTF-8. [x]: SHOULD Reviewer should test that the package builds in mock. [x]: SHOULD If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: SHOULD Dist tag is present. [x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [?]: SHOULD Package functions as described. Couldn't build the package for fedora 16 [x]: SHOULD Package does not include license text files separate from upstream. [x]: SHOULD Scriptlets must be sane, if used. [x]: SHOULD SourceX is a working URL. [x]: SHOULD Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: SHOULD Package should compile and build into binary rpms on all supported architectures. Koji scratch build for rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=3743972 However, note that the build fails for f16: http://koji.fedoraproject.org/koji/taskinfo?taskID=3743987 [-]: SHOULD %check is present and all tests pass. [x]: SHOULD Packages should try to preserve timestamps of original installed files. [x]: SHOULD Spec use %global instead of %define. Issues: [!]: MUST Rpmlint output is silent. rpmlint gtkd-1.5.1-15.20120113svn920.fc17.src.rpm gtkd.src: I: enchant-dictionary-not-found en_US gtkd.src: I: enchant-dictionary-not-found fr gtkd.src: W: invalid-url Source0: gtkd-20120113svn920.tar.xz 1 packages and 0 specfiles checked; 0 errors, 1 warnings. rpmlint gtkd-devhelp-1.5.1-15.20120113svn920.fc17.noarch.rpm gtkd-devhelp.noarch: I: enchant-dictionary-not-found en_US gtkd-devhelp.noarch: I: enchant-dictionary-not-found fr gtkd-devhelp.noarch: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings. rpmlint gtkd-geany-tags-1.5.1-15.20120113svn920.fc17.noarch.rpm gtkd-geany-tags.noarch: I: enchant-dictionary-not-found en_US gtkd-geany-tags.noarch: I: enchant-dictionary-not-found fr gtkd-geany-tags.noarch: W: no-documentation gtkd-geany-tags.noarch: E: script-without-shebang /usr/share/geany/tags/gtkd.d.tags 1 packages and 0 specfiles checked; 1 errors, 1 warnings. rpmlint gtkd-devel-1.5.1-15.20120113svn920.fc17.i686.rpm gtkd-devel.i686: I: enchant-dictionary-not-found en_US gtkd-devel.i686: I: enchant-dictionary-not-found fr gtkd-devel.i686: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings. rpmlint gtkd-1.5.1-15.20120113svn920.fc17.i686.rpm gtkd.i686: I: enchant-dictionary-not-found en_US gtkd.i686: I: enchant-dictionary-not-found fr gtkd.i686: W: unstripped-binary-or-object /usr/lib/libgtkdsv.so.1.5.1 gtkd.i686: W: unstripped-binary-or-object /usr/lib/libgtkdgl.so.1.5.1 gtkd.i686: W: unstripped-binary-or-object /usr/lib/libgtkd.so.1.5.1 1 packages and 0 specfiles checked; 0 errors, 3 warnings. - Fix the script-without-shebang error in rpmlint output - Fix the unstripped-binary-or-object warning (or justify it) - Put the static libraries in a -static package - The license is unclear. according to the source files, it should be LGPLv2.1+ instead of LGPLv3. You should clarify this point with upstream. - Explain in the spec file why you use explicit requires - Some english sentences need to be corrected - Can you fix the build for fedora 16? - You're doing some modifications with sed. You should provide the corresponding upstream bug tickets Generated by fedora-review 0.1.2 External plugins: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
