Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=785639 --- Comment #2 from Bohuslav Kabrda <bkab...@redhat.com> 2012-01-30 03:55:24 EST --- - Run the specs -- Add BR: rubygem(rspec-core) and BR: rubygem(nokogiri) -- Comment out/delete the first two lines in spec/helper.rb to avoid the unnecessary simplecov dependency. -- Run the tests like "rspec spec" in %geminstdir - note that you will probably need to add some load paths later with Ruby 1.9.3. - Other than that, the package looks fine. I would maybe consider using %exclude in %files section rather than removing files with "rm" in %install, but this is definitely not a blocker. So please run the rspecs and then this package can be approved. (When building for rawhide, please save yourself some work and build it right into the f17-ruby target, it will be merged into rawhide anyway.) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
