Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=784592 --- Comment #4 from Mohamed El Morabity <pikachu.2...@gmail.com> 2012-01-30 17:13:15 EST --- Some comments for the moment: - you can get rid of dos2unix as BR, since sed can do the same without bringing an extra BR. You can have a look at this page: http://fedoraproject.org/wiki/Packaging_tricks#Remove_DOS_line_endings - jakarta-commons-logging was renamed apache-commons-logging for a moment. Please use the new name for this dependency. - %defattr is no longer needed: http://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions The patches look good for me by the way. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
