Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=772432 Jens Petersen <peter...@redhat.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #2 from Jens Petersen <peter...@redhat.com> 2012-02-01 00:18:16 EST --- The defattr's can also be dropped. Here is the review: +:ok, NA: not applicable, !: needs attention MUST Items: [!] MUST: rpmlint output [1] gnome-applet-sensors.src: W: spelling-error %description -l en_US customizable -> customization 1 packages and 0 specfiles checked; 0 errors, 1 warnings. gnome-applet-sensors-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/sensors-applet-3.0.0/plugins/pmu-sys/pmu-sys-plugin.c gnome-applet-sensors-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/sensors-applet-3.0.0/plugins/eee/eee-plugin.c gnome-applet-sensors-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/sensors-applet-3.0.0/plugins/udisks/udisks-plugin.c gnome-applet-sensors-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/sensors-applet-3.0.0/sensors-applet/sensors-applet-gconf.c gnome-applet-sensors-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/sensors-applet-3.0.0/sensors-applet/sensors-applet-gconf.h gnome-applet-sensors-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/sensors-applet-3.0.0/sensors-applet/about-dialog.h gnome-applet-sensors-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/sensors-applet-3.0.0/plugins/i8k/i8k-plugin.c gnome-applet-sensors-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/sensors-applet-3.0.0/sensors-applet/about-dialog.c gnome-applet-sensors-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/sensors-applet-3.0.0/plugins/acpi/acpi-plugin.c gnome-applet-sensors-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/sensors-applet-3.0.0/plugins/ibm-acpi/ibm-acpi-plugin.c gnome-applet-sensors-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/sensors-applet-3.0.0/plugins/smu-sys/smu-sys-plugin.c gnome-applet-sensors-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/sensors-applet-3.0.0/sensors-applet/active-sensor-libnotify.c gnome-applet-sensors-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/sensors-applet-3.0.0/sensors-applet/active-sensor-libnotify.h gnome-applet-sensors-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/sensors-applet-3.0.0/sensors-applet/sensors-applet.c gnome-applet-sensors-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/sensors-applet-3.0.0/lib/sensors-applet-plugin.c gnome-applet-sensors-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/sensors-applet-3.0.0/sensors-applet/sensors-applet-sensor.h gnome-applet-sensors-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/sensors-applet-3.0.0/plugins/hddtemp/hddtemp-plugin.c gnome-applet-sensors-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/sensors-applet-3.0.0/sensors-applet/sensor-config-dialog.h gnome-applet-sensors-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/sensors-applet-3.0.0/sensors-applet/sensor-config-dialog.c gnome-applet-sensors-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/sensors-applet-3.0.0/sensors-applet/sensors-applet.h gnome-applet-sensors-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/sensors-applet-3.0.0/sensors-applet/sensors-applet-plugins.c gnome-applet-sensors-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/sensors-applet-3.0.0/sensors-applet/sensors-applet-plugins.h gnome-applet-sensors-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/sensors-applet-3.0.0/plugins/omnibook/omnibook-plugin.c gnome-applet-sensors-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/sensors-applet-3.0.0/plugins/mbmon/mbmon-plugin.c gnome-applet-sensors-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/sensors-applet-3.0.0/sensors-applet/sensors-applet-plugin.h gnome-applet-sensors-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/sensors-applet-3.0.0/plugins/libsensors/libsensors-plugin.c gnome-applet-sensors-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/sensors-applet-3.0.0/sensors-applet/active-sensor.h gnome-applet-sensors-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/sensors-applet-3.0.0/sensors-applet/active-sensor.c gnome-applet-sensors-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/sensors-applet-3.0.0/plugins/sonypi/sonypi-plugin.c gnome-applet-sensors-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/sensors-applet-3.0.0/sensors-applet/main.c gnome-applet-sensors-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/sensors-applet-3.0.0/sensors-applet/prefs-dialog.h gnome-applet-sensors-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/sensors-applet-3.0.0/sensors-applet/prefs-dialog.c 1 packages and 0 specfiles checked; 32 errors, 0 warnings. gnome-applet-sensors-devel.x86_64: W: no-documentation gnome-applet-sensors-devel.x86_64: E: incorrect-fsf-address /usr/include/sensors-applet/sensors-applet-plugin.h gnome-applet-sensors-devel.x86_64: E: incorrect-fsf-address /usr/include/sensors-applet/sensors-applet-sensor.h 1 packages and 0 specfiles checked; 2 errors, 1 warnings. ** Could you please contact upstream and ask them to update the FSF address in their source headers? ** gnome-applet-sensors.x86_64: W: spelling-error %description -l en_US customizable -> customization gnome-applet-sensors.x86_64: W: undefined-non-weak-symbol /usr/lib64/libsensors-applet-plugin.so.0.0.0 plugin_name gnome-applet-sensors.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsensors-applet-plugin.so.0.0.0 linux-vdso.so.1 1 packages and 0 specfiles checked; 0 errors, 3 warnings. The unused-direct-shlib-dependency warning seems bogus: the included plugins link to the library. I think the weak symbol warning can probably be waived. [+] MUST: package named according to Package Naming Guidelines [+] MUST: spec file name must match base package %{name} [2] [+] MUST: meet Packaging Guidelines [+] MUST: Fedora approved license and Licensing Guidelines [+] MUST: License field in the package spec file must match actual license. [3] [+] MUST: include license files in %doc if available in source [4] [+] MUST: The spec file must be written in American English [5] and legible. [6] [+] MUST: source md5sum matches upstream release (from upstream URL) 425078fc1ff5a98af1547e039002a73f sensors-applet-3.0.0.tar.gz [+] MUST: successfully compile and build into binary rpms on a primary arch [7] [NA] MUST: if necessary use ExcludeArch for other archs [8] [+] MUST: All build dependencies must be listed in BuildRequires http://koji.fedoraproject.org/koji/taskinfo?taskID=3750932 [+] MUST: use %find_lang macro for .po translations [9] [+] MUST: packages which store shared library files in the dynamic linker's default paths, must call ldconfig in %post and %postun. [10] [+] MUST: Packages must NOT bundle copies of system libraries. [11] [NA] MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review [12] [!] MUST: A package must own all directories that it creates. [13] /usr/share/sensors-applet/ is unowned! [+] MUST: A package must not contain any duplicate files in the %files listing. [14] [+] MUST: Permissions on files must be set properly. [15] [+] MUST: consistently use macros [16] [+] MUST: The package must contain code, or permissable content. [17] [NA] MUST: Large documentation files should go in a doc subpackage. [18] [+] MUST: If a package includes something as %doc, it must not affect the runtime of the application. [18] [+] MUST: Header files must be in a -devel package. [19] [NA] MUST: Static libraries must be in a -static package. [20] [+] MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package. [19] [+] MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency [21] [+] MUST: Packages must NOT contain any .la libtool archives, these should be removed in the spec. [20] [NA] MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. [22] [+] MUST: Packages must not own files or directories already owned by other packages. [23] [+] MUST: All filenames in rpm packages must be valid UTF-8. [24] SHOULD Items: [+] SHOULD: The reviewer should test that the package builds in mock. [27] [+] SHOULD: The reviewer should test that the package functions as described. A package should not segfault instead of running, for example. [+] SHOULD: If scriptlets are used, those scriptlets must be sane. [29] Package is APPROVED: but please fix the missing ownership of /usr/share/sensors-applet when importing the updated .spec file into git, and please contact upstream about the old FSF address in the src headers. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
