Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=772751 --- Comment #6 from Bob Kukura <rkuk...@redhat.com> 2012-02-07 11:58:22 EST --- Pete, This is close to ready. Here are this questions/issues I found: 1) Is the python_sitelib definition on the 1st line needed? If not, please remove it. 2) Why is Group commented out in the spec? Enable it unless there is a reason not to. 3) List BuildRequires each on separate lines. 4) Use python-setuptools rather than python-setuptools-devel in BuildRequires. 5) Add any needed Requires lines for runtime (i.e. "Requires: git"). 6) Add "%dir %{_sysconfdir}/git-review" so that the RPM owns the /etc/git-review directory. 7) Replace spaces with tabs on line 15. 8) Replace "%" with "%%" in comment on line 48, or remove comment if not needed. -Bob -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
