Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=788252 --- Comment #4 from Russell Bryant <rbry...@redhat.com> 2012-02-08 10:18:08 EST --- Thanks for the review, everyone! I have made some updates: 1) Renamed the package to pysendfile to match upstream 2) Added a %check section to run the unit tests 3) Remove unnecessary removal of the buildroot in %install section Regarding the issue pointed out by fedora-review, I don't think that is correct for this package. That so is the Python module itself, so it shouldn't be in a devel package. I believe that check is designed for a C/C++ package, not a Python package. Spec: http://fedorapeople.org/~russellb/pysendfile/pysendfile.spec SRPM: http://fedorapeople.org/~russellb/pysendfile/pysendfile-2.0.0-2.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
