Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=786587 Jamie Nguyen <ja...@tomoyolinux.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ja...@tomoyolinux.co.uk --- Comment #1 from Jamie Nguyen <ja...@tomoyolinux.co.uk> 2012-02-09 07:31:57 EST --- Hello, some comments: 1) /usr/bin/gtk-update-icon-cache shouldn't be a dependency: http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache 2) BuildRequires are missing, which I eventually realized was because the listed BuildRequires are part of the %description and so not processed. 3) rm is preferred over %{__rm} (and same with mkdir). http://fedoraproject.org/wiki/Packaging:Guidelines#Macros 4) If not building for EPEL, you can remove BuildRoot tag, remove "rm -rf $RPM_BUILD_ROOT" from %install section, and remove %clean section. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
