Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=789332

--- Comment #8 from Petr Ĺ abata <psab...@redhat.com> 2012-02-13 04:49:36 EST ---
(In reply to comment #4)
> (In reply to comment #1)
> > TODO: Use %{_bindir} in git file requirements instead of hardcoded /usr/bin
> 
> That's an interesting catch. With /usr move, it makes sense to avoid 
> hardcoding
> paths, but technically, Git-Repository only needs git somewhere in $PATH. How
> about just {Build,}Requires: git?

You'd run in other problems if the git maintainer decides to package the git
binary in git-cli or something.  File-based dependency is somewhat safer (well,
that's just my opinion).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to