Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=738746

--- Comment #7 from Bohuslav "Slavek" Kabrda <bkab...@redhat.com> 2012-02-29 
02:07:02 EST ---
- Please bump the release when doing changes (you can use rpmdev-bumpspec) - or
if you are updating to newer version, you still need to add a changelog entry,
that notes it.
- According to [1], you can use the new macros for gem files and directories.
The only thing you need to do is define %gem_name, then you will have
%gem_instdir, %gem_cache, etc... Also, you should now have BR: rubygems-devel
instead of BR: ruby(rubygems) (the runtime dependency however stays on
ruby(rubygems) ).
- If there are tests available in the upstream, that are not present in the gem
itself, it a good custom to run them. You can see rubygem-delorean as an
example how to do that (you have to check them out from git separately in the
correct version and add them as another source).

[1] https://fedoraproject.org/wiki/PackagingDrafts/Ruby#Macros

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to