Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=800720

--- Comment #1 from Juan Hernández <juan.hernan...@redhat.com> 2012-03-07 
04:26:46 EST ---
I would like to take this for review, but someone has to review glassfish-jaxb 
and glassfish-fi first, as they are dependencies, otherwise I can't build in
Koji.

Meanwhile I would suggest the following minor changes in the spec:

* Change the summary so that it doesn't contain the name of the package
(rpmlint complains about that).
* Remove commented out lines (otherwise rpmlint complains about macros in
comments).
* Include the license as %doc in the javadoc subpackage.
* Replace tomcat6 with tomcat (version 7), if possible.
* Add comments describing the purpose of the patches.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to