Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=803089 --- Comment #9 from Michael Scherer <m...@zarb.org> 2012-03-22 02:56:56 EDT --- So : - The guideline say that you should use %global instead of %define : https://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define - there is no need nowadays to clean the buildroot before install https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag - the line %define opt %(test -x %{_bindir}/ocamlopt && echo 1 || echo 0) is still not used. If you have added directly support in the makefile, then this line can be removed, no ? - why are debug disabled ? While I am sure that you have good reasons, it should be mentioned in a comment ( and that's maybe the reason why you have to strip by hand the software, as you mention later in the spec ) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
