Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=611372 Petr Šabata <psab...@redhat.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #19 from Petr Šabata <psab...@redhat.com> 2012-03-27 11:33:16 EDT --- (In reply to comment #18) > (In reply to comment #17) > > So, after going through the deps again, I see only perl(Net::Netrc) doesn't > > get > > autodetected and you should require it explicitly. > > I left that out deliberately since the author says reading credentials from > .netrc is an optional feature; Fair enough. > the "require" is wrapped in an "if" statement in > the code. Do you think it should be included as a dep unconditionally? I'm > happy to include it as an extra Requires if you think it makes sense. It's up to you. If you think most users would benefit from it, it might be a good idea. Approving. (You should now submit an SCM request.) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
