Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=225902 Kalev Lember <kalevlem...@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kalevlem...@gmail.com --- Comment #7 from Kalev Lember <kalevlem...@gmail.com> 2012-04-10 04:41:02 EDT --- Hi Jon, Thanks for taking care of this. I took a look at the changes done here because of new build failures on rawhide. A few comments: > -BuildRequires: gettext > +BuildRequires: gettext-devel Why is it necessary to change this? It used to build fine with BR: gettext as it only needs the tools from gettext package for building and doesn't use the headers that are in -devel. > -Requires: gettext-devel > +Requires: gettext Requiring gettext-devel was a deliberate change in http://pkgs.fedoraproject.org/gitweb/?p=intltool.git;a=commit;h=b5cc8a4b . If you ever need to find out why some line is the way it is, 'git blame' can help for history digging. Packages that used to rely on intltool dragging in gettext-devel are now failing to build, e.g. gtranslator: http://koji.fedoraproject.org/koji/buildinfo?buildID=312458 If you think it's important to depend on gettext instead of gettext-devel, can you send out a heads up to fedora-devel list that packages will now have to explicitly BR gettext-devel, instead of relying on intltool dragging it in? I fear the ARM secondary arch people aren't very happy about new FTBFS failures, so it's best to try to get package maintainers to fix these early. > -Obsoletes: xml-i18n-tools > -Provides: xml-i18n-tools = 0.11 > +#Obsoletes: xml-i18n-tools > +#Provides: xml-i18n-tools = 0.11 Perhaps remove these lines completely, to avoid cluttering the spec file with commented out lines? Any changes are permanently recorded in git history, so it's always possible to revert them at a later date. Thanks again for taking care of the merge review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
