Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=789055 Richard Shaw <hobbes1...@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flag| |fedora-review? --- Comment #4 from Richard Shaw <hobbes1...@gmail.com> 2012-04-19 14:14:20 EDT --- Spec looks good and it did build for rawhide for me in mock. Rpmlint produces some output, largely FSF address related: japa-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/japa-0.6.0/rngen.h japa-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/japa-0.6.0/audio.h japa-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/japa-0.6.0/messages.h japa-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/japa-0.6.0/styles.cc japa-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/japa-0.6.0/gobjects.cc japa-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/japa-0.6.0/analyser.cc japa-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/japa-0.6.0/analyser.h japa-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/japa-0.6.0/gobjects.h japa-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/japa-0.6.0/audio.cc japa-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/japa-0.6.0/prbsgen.h japa-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/japa-0.6.0/mainwin.h japa-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/japa-0.6.0/mainwin.cc japa-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/japa-0.6.0/japa.cc japa-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/japa-0.6.0/styles.h japa-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/japa-0.6.0/rngen.cc Those should be reported upstream... Also, desktop-file-install complains a little but fixes the problem. This should probably be reported upstream as well: + desktop-file-install --dir /builddir/build/BUILDROOT/japa-0.6.0-2.fc18.x86_64/usr/share/applications /builddir/build/SOURCES/japa.desktop /builddir/build/SOURCES/japa.desktop: warning: key "Categories" is a list and does not have a semicolon as trailing character, fixing I'll start the formal review as soon as I get a little time. For now, back to work for me! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
